Draft
Conversation
PatrickvL
reviewed
Nov 10, 2021
| static inline bool internal_IsXRefUnset(uint16_t XRef) | ||
| { | ||
| return (XRef == (uint16_t)XREF_ADDR_UNDETERMINED) || (XRef == XREF_ADDR_DERIVE); | ||
| return (XRef == XREF_UNDETERMINED) || (XRef <= XREF_KT_COUNT); |
Member
There was a problem hiding this comment.
Why is the second test changed?
Member
Author
There was a problem hiding this comment.
internal_IsXRefUnset is intended to check if xref is set for database's symbols that are grouped together. Plus cannot have kernel thunk references from the database's symbols. So, that's consider as not set. There's two difference between internal_IsXRefUnset and internal_IsXRefAddrUnset. internal_IsXRefAddrUnset is designed for check xref_database's array that is cached.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review remarks are currently welcome at this time and any new internal tests as well.
Reasons this pull request is draft:
List of self-tests added:
List of below is pretty much rules should be follow which will be likely copy over to wiki page.
stdcallsymbol is used, then it require to be normal name unless later API has changed to add / remove parameter._#suffix is required.__r1suffix or the like. This decision had not been made.CDirectSoundStream_GetStatusas an example does not fall under this category. Since the internal function had changed a bit.__LTCGsuffix is required along with which parameters are assigned to either onto stack or registers. We only need registers assigned, parameters on the stack is not a requirement.List of current reports as of commit d60c19a
SymbolDatabaseVerifyContext_VerifyXRefJmp:
SymbolDatabaseVerifyContext_VerifySymbolDuplicate: